Add some linting to gaia #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- closes #187 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
golangcibot
reviewed
Nov 7, 2019
tac0turtle
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
approved these changes
Nov 11, 2019
lcd_test/helpers.go
Outdated
| @@ -151,8 +151,7 @@ func defaultGenesis(config *tmcfg.Config, nValidators int, initAddrs []sdk.AccAd | |||
|
|
|||
| // append any additional (non-proposing) validators | |||
| var genTxs []auth.StdTx | |||
| var genAccounts []authexported.GenesisAccount | |||
|
|
|||
| genAccounts := make([]authexported.GenesisAccount, 0) | |||
There was a problem hiding this comment.
don't preallocate to 0, just add nolint
There was a problem hiding this comment.
even better, you already know the size to allocate: len(initAddrs) + nValidators
There was a problem hiding this comment.
len(initAddrs) + nValidators this seems to be causing most the tests in lcd_test to fail
There was a problem hiding this comment.
are you setting values in the array correctly? i.e. genAccounts[genAccsIdx] = genAccount
alexanderbez
previously requested changes
Nov 11, 2019
lcd_test/helpers.go
Outdated
| @@ -151,8 +151,7 @@ func defaultGenesis(config *tmcfg.Config, nValidators int, initAddrs []sdk.AccAd | |||
|
|
|||
| // append any additional (non-proposing) validators | |||
| var genTxs []auth.StdTx | |||
| var genAccounts []authexported.GenesisAccount | |||
|
|
|||
| genAccounts := make([]authexported.GenesisAccount, 0) | |||
There was a problem hiding this comment.
even better, you already know the size to allocate: len(initAddrs) + nValidators
jackzampolin
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: